graph/simple: factor ID handling out of graph types #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimir-ch
approved these changes
May 29, 2017
graph/simple/simple.go
Outdated
| @@ -43,3 +45,37 @@ const maxInt int = int(^uint(0) >> 1) | |||
| func isSame(a, b float64) bool { | |||
| return a == b || (math.IsNaN(a) && math.IsNaN(b)) | |||
| } | |||
|
|
|||
| // idset implements available ID storage. | |||
graph/simple/simple.go
Outdated
| // newID returns a new unique ID. | ||
| func (s *idSet) newID() int { | ||
| var id int | ||
| if s.free.Len() != 0 && s.free.TakeMin(&id) { |
There was a problem hiding this comment.
This can be simplified to just if s.free.TakeMin(&id) { but on the other hand it is less explicit.
There was a problem hiding this comment.
I think this is residual from when the behaviour was map-based. I've made the change, but it looks like we may end up back at the map-based approach anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preparation for adding
ID() intto thegraph.Edgeinterface.@vladimir-ch Please take a look.