Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: cleanup spelling, ineffassign and vet errors #78

Merged
merged 3 commits into from Jun 20, 2017
Merged

Conversation

kortschak
Copy link
Member

This covers most of the errors found by goreport here.

@btracey @vladimir-ch @sbinet Please take a look.

Many are left, either because the code is not idiomatic and derived from
other implementations or there is a reason behind the assignment.
@kortschak
Copy link
Member Author

I'll wait for @btracey and @sbinet as well.

@@ -553,7 +553,7 @@ func (l *directedLocalMover) deltaQ(n graph.Node) (deltaQ float64, dst int, src
m := l.m
gamma := l.resolution

// Find communites connected to n.
// Find communities connected to n.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! It's not just me who can't spell.

@kortschak
Copy link
Member Author

@sbinet ping There is code here that you wrote and I want to make sure I have the semantics correct.

@kortschak kortschak merged commit 7af70dd into master Jun 20, 2017
@kortschak kortschak deleted the goreport branch June 20, 2017 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants