lapack/gonum: fix various bugs in Dgetri #806
Conversation
|
The block size adjustment is not covered by Dgetri's test, so should be added too (later). |
| @@ -49,7 +49,7 @@ func (impl Implementation) Dgetri(n int, a []float64, lda int, ipiv []int, work | |||
| if nb > 1 && nb < n { | |||
| iws := max(ldwork*n, 1) | |||
| if lwork < iws { | |||
| nb = lwork / ldwork | |||
| nb = lwork / n | |||
There was a problem hiding this comment.
This doesn't look like a row vs col major issue, so does this affect the NETLIB implementation as well?
There was a problem hiding this comment.
It is a row vs column major issue. This line calculates "how many columns fit into the workspace we have". For reference the column size is ldwork, for us it's n.
There was a problem hiding this comment.
Ah, yes, the assignment to ldwork above. Thanks.
| } | ||
| bi.Dtrsm(blas.Right, blas.Lower, blas.NoTrans, blas.Unit, n, jb, 1, work[j*ldwork:], ldwork, a[j:], lda) |
There was a problem hiding this comment.
Nasty non-bracketed conditional blocks!
There was a problem hiding this comment.
Yeah, the code there is particularly difficult to parse. I had to stare on it for a while and still wasn't completely sure if dtrsm is under the if or not.
|
PTAL |
|
It's ok, I'll merge as it is. |
Fixes #805
Please take a look.