unit: remove explicitly prefixed constants #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimir-ch
reviewed
Apr 12, 2019
unit/generate_unit.go
Outdated
| Receiver string | ||
| Offset int // From normal (for example, mass base unit is kg, not kg) | ||
| PowerOffset int // From normal (for example, mass base unit is kg, not kg) |
unit/generate_unit.go
Outdated
| DimensionName: "Area", | ||
| Receiver: "a", | ||
| PrintString: "m^2", | ||
| TypeComment: "Area represents and area in square metres", |
|
PTAL |
vladimir-ch
approved these changes
Apr 12, 2019
There was a problem hiding this comment.
I approve it but cannot tell whether you should wait for @btracey or not, I haven't been paying much attention to unit.
|
I'll wait. |
|
That's such an obvious solution to the Kg problem ... can't believe I didn't think of that. |
btracey
approved these changes
Apr 13, 2019
|
Which part, the extra constant or the 1e-3? |
|
Setting the gram to be 1e-3. |
|
When you remove all the constants, that's what was left. It seemed obvious. |
|
I agree, it does seem obvious |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a look.
Closes #90.