{internal,search}: remove ByComponentLengthOrStart

This sort order was a lazy solution to sorting [][]int, so remove it.

internal/sort.go

@@ -4,14 +4,8 @@
 
 package internal
 
-type ByComponentLengthOrStart [][]int
-
-func (c ByComponentLengthOrStart) Len() int { return len(c) }
-func (c ByComponentLengthOrStart) Less(i, j int) bool {
-	return len(c[i]) < len(c[j]) || (len(c[i]) == len(c[j]) && c[i][0] < c[j][0])
-}
-func (c ByComponentLengthOrStart) Swap(i, j int) { c[i], c[j] = c[j], c[i] }
-
+// BySliceValues implements the sort.Interface sorting a slice of
+// []int lexically by the values of the []int.
 type BySliceValues [][]int
 
 func (c BySliceValues) Len() int { return len(c) }

search/search_test.go

@@ -361,7 +361,8 @@ var tarjanTests = []struct {
 			{0, 2},
 		},
 		want: [][]int{
-			{3, 4}, {0, 1, 2},
+			{0, 1, 2},
+			{3, 4},
 		},
 	},
 }
@@ -390,8 +391,8 @@ func TestTarjanSCC(t *testing.T) {
 			sort.Ints(gotIDs[i])
 		}
 		for _, iv := range test.ambiguousOrder {
-			sort.Sort(internal.ByComponentLengthOrStart(test.want[iv.start:iv.end]))
-			sort.Sort(internal.ByComponentLengthOrStart(gotIDs[iv.start:iv.end]))
+			sort.Sort(internal.BySliceValues(test.want[iv.start:iv.end]))
+			sort.Sort(internal.BySliceValues(gotIDs[iv.start:iv.end]))
 		}
 		if !reflect.DeepEqual(gotIDs, test.want) {
 			t.Errorf("unexpected Tarjan scc result for %d:\n\tgot:%v\n\twant:%v", i, gotIDs, test.want)