hdf5: fix build for >go1.8 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kortschak
commented
Aug 10, 2017
| @@ -188,7 +188,7 @@ func (t *Datatype) Size() uint { | |||
| } | |||
|
|
|||
| // SetSize sets the total size of a Datatype. | |||
| func (t *Datatype) SetSize(sz uint) error { | |||
| func (t *Datatype) SetSize(sz int) error { | |||
There was a problem hiding this comment.
Note that this is incorrect for 32 bit systems (but so was the previous code).
Either there should be a build tag for the 32 bit case, or there should be a special case for -1 to send int64(-1), or sz should be int64.
There was a problem hiding this comment.
Actually, on a 32 bit arch, int and size_t are probably still the same size (though not guaranteed). I think we may want to have some init checks for things like this at some stage.
sbinet
approved these changes
Aug 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sbinet Please take a look.