Pr comments

gonum · Jan 7, 2016 · 7ba7302 · 7ba7302
1 parent 4339163
commit 7ba7302
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/native/dgesvd.go b/native/dgesvd.go
@@ -1346,13 +1346,13 @@ func (impl Implementation) Dgesvd(jobU, jobVT lapack.SVDJob, m, n int, a []float
 		if anrm > bignum {
 			impl.Dlascl(lapack.General, 0, 0, bignum, anrm, minmn, 1, s, minmn)
 		}
-		if ok && anrm > bignum {
+		if !ok && anrm > bignum {
 			impl.Dlascl(lapack.General, 0, 0, bignum, anrm, minmn-1, 1, work[minmn:], minmn)
 		}
 		if anrm < smlnum {
 			impl.Dlascl(lapack.General, 0, 0, smlnum, anrm, minmn, 1, s, minmn)
 		}
-		if ok && anrm < smlnum {
+		if !ok && anrm < smlnum {
 			impl.Dlascl(lapack.General, 0, 0, smlnum, anrm, minmn-1, 1, work[minmn:], minmn)
 		}
 	}

diff --git a/testlapack/dgesvd.go b/testlapack/dgesvd.go
@@ -200,7 +200,6 @@ func svdCheckPartial(t *testing.T, impl Dgesvder, job lapack.SVDJob, errStr stri
 	}
 	impl.Dgesvd(jobU, jobVT, m, n, a, lda, s, tmp1, ldu, vt, ldvt, work, len(work))
 	if !floats.EqualApprox(vtAll, vt, 1e-10) {
-		fmt.Println("vtmismatch")
 		t.Errorf("VT mismatch when U is not computed: %s", errStr)
 	}
 	if !floats.EqualApprox(s, sCopy, 1e-10) {