This repository has been archived by the owner on Dec 10, 2018. It is now read-only.
Replace Eigen with lapack-based implementation #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like the best signature for Factorize, but I'm a bit worried about the confusion it will cause. I think many users have only heard of "eigenvectors" and don't realize the two classes. I'm hoping that the documentation and the name asymmetry (which in my vision will eventually become Eigenvectors and LeftEigenvectors as methods on Dense) points users to what they want. |
kortschak
approved these changes
Mar 17, 2017
mat64/eigen.go
Outdated
| // | ||
| // This signature and behavior will change when issue #308 is resolved. | ||
| // See the documentation in lapack64.Geev for the format of the vectors. |
There was a problem hiding this comment.
Can we have documentation for this here rather than pointing users to lapack.
Closed
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.