Merge e76f51d into 29ff885

.travis.yml

@@ -49,6 +49,8 @@ matrix:
     env: BLAS_LIB=OpenBLAS
 
 before_install:
+ # Required for format check.
+ - go get golang.org/x/tools/cmd/goimports
  # Required for code get checks.
  - go mod download gonum.org/v1/gonum || true
  # Required for imports check.
@@ -66,9 +68,9 @@ install:
  - travis_wait 20 ${TRAVIS_BUILD_DIR}/.travis/$TRAVIS_OS_NAME/$BLAS_LIB/install.sh
 
 script:
- - ${TRAVIS_BUILD_DIR}/.travis/check-imports.sh
  - ${TRAVIS_BUILD_DIR}/.travis/check-copyright.sh
+ - ${TRAVIS_BUILD_DIR}/.travis/check-imports.sh
+ - ${TRAVIS_BUILD_DIR}/.travis/check-formatting.sh
  - ${TRAVIS_BUILD_DIR}/.travis/$TRAVIS_OS_NAME/$BLAS_LIB/test.sh
- - test -z "$(gofmt -d .)"
  # This is run last since it alters the tree.
  - ${TRAVIS_BUILD_DIR}/.travis/check-generate.sh

.travis/check-formatting.sh

@@ -0,0 +1,8 @@
+#!/bin/bash
+
+test -z "$(goimports -d .)"
+if [[ -n "$(gofmt -s -l .)" ]]; then
+	echo -e '\e[31mCode not gofmt simplified in:\n\n'
+	gofmt -s -l .
+	echo -e "\e[0"
+fi

.travis/check-generate.sh

@@ -7,5 +7,6 @@ go generate gonum.org/v1/netlib/lapack/netlib
 
 git checkout -- go.{mod,sum}
 if [ -n "$(git diff)" ]; then
+	git diff
 	exit 1
 fi

go.mod

@@ -3,7 +3,7 @@ module gonum.org/v1/netlib
 require (
 	github.com/remyoudompheng/bigfft v0.0.0-20170806203942-52369c62f446 // indirect
 	golang.org/x/exp v0.0.0-20190312203227-4b39c73a6495
-	gonum.org/v1/gonum v0.0.0-20190327053044-9996f1428eb6
+	gonum.org/v1/gonum v0.0.0-20190331200053-3d26580ed485
 	modernc.org/cc v1.0.0
 	modernc.org/golex v1.0.0 // indirect
 	modernc.org/mathutil v1.0.0 // indirect

go.sum

@@ -13,8 +13,8 @@ golang.org/x/sys v0.0.0-20190312061237-fead79001313/go.mod h1:h1NjWce9XRLGQEsW7w
 golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
 golang.org/x/tools v0.0.0-20190206041539-40960b6deb8e/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ=
 golang.org/x/tools v0.0.0-20190312151545-0bb0c0a6e846/go.mod h1:LCzVGOaR6xXOjkQ3onu1FJEFr0SW1gC7cKk1uF8kGRs=
-gonum.org/v1/gonum v0.0.0-20190327053044-9996f1428eb6 h1:J2E8+RF2MJbp5ElkVuqonc7ZcRO/eeU5vWMNCt0YgFY=
-gonum.org/v1/gonum v0.0.0-20190327053044-9996f1428eb6/go.mod h1:2ltnJ7xHfj0zHS40VVPYEAAMTa3ZGguvHGBSJeRWqE0=
+gonum.org/v1/gonum v0.0.0-20190331200053-3d26580ed485 h1:OB/uP/Puiu5vS5QMRPrXCDWUPb+kt8f1KW8oQzFejQw=
+gonum.org/v1/gonum v0.0.0-20190331200053-3d26580ed485/go.mod h1:2ltnJ7xHfj0zHS40VVPYEAAMTa3ZGguvHGBSJeRWqE0=
 gonum.org/v1/netlib v0.0.0-20190313105609-8cb42192e0e0/go.mod h1:wa6Ws7BG/ESfp6dHfk7C6KdzKA7wR7u/rKwOGE66zvw=
 modernc.org/cc v1.0.0 h1:nPibNuDEx6tvYrUAtvDTTw98rx5juGsa5zuDnKwEEQQ=
 modernc.org/cc v1.0.0/go.mod h1:1Sk4//wdnYJiUIxnW8ddKpaOJCF37yAdqYnkxUpaYxw=

lapack/netlib/lapack_test.go

@@ -165,7 +165,8 @@ func TestDgerqf(t *testing.T) {
 }
 
 func TestDgesvd(t *testing.T) {
-	testlapack.DgesvdTest(t, impl)
+	const tol = 1e-12
+	testlapack.DgesvdTest(t, impl, tol)
 }
 
 func TestDgetf2(t *testing.T) {