lapack/netlib: relax tolerance of TestDgesvd #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kortschak
force-pushed
the
lapack/tol-dgesvd
branch
from
caff090
to
b807ee3
Compare
vladimir-ch
previously approved these changes
Mar 30, 2019
|
I'm not sure this will pass yet. I tried 1e-12 and that failed. We'll see how we go. |
|
BTW It is only the 300x150 mtype=5 that fails. |
|
This is still failing at 1e-11. I'm going to look at it again tomorrow. |
|
Figured out why. This wasn't using the constant. |
kortschak
force-pushed
the
lapack/tol-dgesvd
branch
2 times, most recently
from
a0884e9
to
6055bac
Compare
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
=======================================
Coverage 29.64% 29.64%
=======================================
Files 2 2
Lines 6382 6382
=======================================
Hits 1892 1892
Misses 4047 4047
Partials 443 443Continue to review full report at Codecov.
|
kortschak
force-pushed
the
lapack/tol-dgesvd
branch
from
6055bac
to
8e9ba46
Compare
|
Sorry, that was hopefully to dismiss the approval. This is not ready until I can update go.mod to the appropriate commit. That depends on gonum/gonum#940. |
kortschak
force-pushed
the
lapack/tol-dgesvd
branch
from
8e9ba46
to
e76f51d
Compare
vladimir-ch
approved these changes
Mar 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a look.
Fixes #58.