lapack/netlib: allocate work in Dlantr when necessary #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 30, 2019
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
=========================================
+ Coverage 29.64% 29.9% +0.25%
=========================================
Files 2 2
Lines 6382 6384 +2
=========================================
+ Hits 1892 1909 +17
+ Misses 4047 4039 -8
+ Partials 443 436 -7
Continue to review full report at Codecov.
|
kortschak
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are row-major, for our Go implementation it makes sense to use
workof lengthnfor the L-1 norm (MaxColumSum). However, LAPACKE just forwardsworkto the Fortran reference which is column-major and uses it for L-infinity norm (MaxRowSum) and needs length ofm.The module dance is to get Gonum 0.6.0.
Please take a look.