Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lapack/netlib: add Dtbtrs #77

Merged
merged 2 commits into from Oct 12, 2020
Merged

lapack/netlib: add Dtbtrs #77

merged 2 commits into from Oct 12, 2020

Conversation

vladimir-ch
Copy link
Member

Please take a look.

lapack/netlib/lapack.go Outdated Show resolved Hide resolved
kortschak
kortschak previously approved these changes Oct 11, 2020
lapack/netlib/lapack.go Outdated Show resolved Hide resolved
@vladimir-ch
Copy link
Member Author

I think I still haven't figured out how to update this repo in sync with gonum with modules. I have to run go get -u gonum.org/v1/gonum@master to get rid of the travis failure, right? Is that the expected workflow?

@kortschak
Copy link
Member

Because we are actually versioned now, you need to do go get gonum.org/v1/gonum@eea0b5cb5cc92420e0be3a49bbdaeb8aa32d309b (I chose the oldest commit that would support this, but you can use the master sha.

@vladimir-ch
Copy link
Member Author

Ok, done.

@codecov-io
Copy link

codecov-io commented Oct 11, 2020

Codecov Report

Merging #77 into master will decrease coverage by 0.00%.
The diff coverage is 37.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
- Coverage   29.01%   29.01%   -0.01%     
==========================================
  Files           3        3              
  Lines        6249     6277      +28     
==========================================
+ Hits         1813     1821       +8     
- Misses       4003     4023      +20     
  Partials      433      433              
Impacted Files Coverage Δ
lapack/netlib/conv.go 100.00% <ø> (ø)
lapack/netlib/lapack.go 29.85% <37.50%> (-0.03%) ⬇️
blas/netlib/blas.go 28.51% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0ca4b3...7f0aa3a. Read the comment docs.

lapack/netlib/lapack.go Outdated Show resolved Hide resolved
@vladimir-ch vladimir-ch merged commit 2390d26 into master Oct 12, 2020
@vladimir-ch vladimir-ch deleted the lapack/add-dtbtrs branch October 12, 2020 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants