Added ColorMap types and legends #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kortschak
reviewed
Nov 7, 2016
|
|
||
| // ColorMapLegend is a plot.Plotter that draws a color bar legend for a ColorMap. | ||
| type ColorMapLegend struct { | ||
| // Vertical determines wether the legend will be |
| // The default is false (horizontal). | ||
| Vertical bool | ||
|
|
||
| // NColors specifies the number of colors to be |
|
|
||
| // StringMap fulfils the ColorMapString interface, mapping integer | ||
| // categories to colors. | ||
| type StringMap struct { |
| // If scalar is outside of the allowed range, an error is returned. | ||
| type ColorMap interface { | ||
| // At returns the color associated with the value scalar. | ||
| At(scalar float64) (color.Color, error) |
There was a problem hiding this comment.
s/scalar/v/ or even s/scalar// (updating the comment).
|
|
||
| // IntMap fulfils the ColorMapInt interface, mapping integer | ||
| // categories to colors. | ||
| type IntMap struct { |
| // If there is no mapped color for the given category, an error is returned. | ||
| type ColorMapInt interface { | ||
| // At returns the color associated with category cat. | ||
| At(cat int) (color.Color, error) |
There was a problem hiding this comment.
s/At/Color/g ?
s/cat/int/g or s/cat/v/g
|
What happened here? |
|
This has become a bit of a mess. It depends on the changes in #321, but in response to comments over there I have moved some of the code from this PR over there. Once that one is merged I will fix this one. |
ctessum
force-pushed
the
moreland
branch
4 times, most recently
from
4f4fdeb
to
235bd2a
Compare
|
This pull request was based on a non-master branch, which has caused some trouble. I will start a new one relative to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to issues #304, #133, and #17