Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis add golang 1.8.1 #349

Merged
merged 1 commit into from
May 1, 2017
Merged

Travis add golang 1.8.1 #349

merged 1 commit into from
May 1, 2017

Conversation

ctessum
Copy link
Contributor

@ctessum ctessum commented Apr 28, 2017

No description provided.

@sbinet
Copy link
Member

sbinet commented Apr 28, 2017 •
edited

perhaps we should just put 1.8.x as per:
https://docs.travis-ci.com/user/languages/go/#Specifying-a-Go-version-to-use

You can use any tagged version of Go, a version with x in place of the minor
or patch level to use the latest for a given major or minor version

@Kunde21
Copy link
Member

Kunde21 commented Apr 28, 2017

We should also add master and allow that one to fail. That lets us test against tip to find any regressions without flagging our build.

@kortschak
Copy link
Member

@Kunde21 That is an excellent idea. I didn't know you could do that.

@ctessum ctessum force-pushed the travis branch 2 times, most recently from 9c600b7 to 7369d44 Compare April 29, 2017 02:43
@ctessum
Copy link
Contributor Author

ctessum commented Apr 29, 2017

Done. PTAL

@kortschak
Copy link
Member

go1.5 can be dropped; we only support three releases.

@ctessum
Copy link
Contributor Author

ctessum commented Apr 30, 2017

Done. Is there some sort of documentation that says these things?

@kortschak
Copy link
Member

No, I don't think there is. We should add that.

kortschak
kortschak approved these changes Apr 30, 2017
View reviewed changes
Copy link
Member

@kortschak kortschak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could have 1.6.x and 1.7.x too, but don't bother now - it can be done when there is only a single file to change across the suite.

@ctessum ctessum merged commit c51bede into master May 1, 2017
@ctessum ctessum deleted the travis branch May 1, 2017 02:23
@ctessum ctessum mentioned this pull request May 1, 2017
Closed
@kortschak kortschak mentioned this pull request Jun 29, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kortschak kortschak kortschak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ctessum @sbinet @Kunde21 @kortschak