vg/vgsvg: bump DPI to 96, introduce functional options #492
Conversation
|
|
||
| // UseDPI sets the dots per inch of a canvas. It should only be | ||
| // used as an option argument when initializing a new canvas. | ||
| func UseDPI(dpi int) option { |
There was a problem hiding this comment.
mainly for consistency with e.g. vg/vgimg.UseDPI.
I can switch to float64 if you prefer. (we're not super consistent on this front, sometimes the DPI field is float64 sometimes int...)
There was a problem hiding this comment.
Let's revisit that in another issue.
sbinet
force-pushed
the
issue-491
branch
2 times, most recently
from
14af1dc
to
d908fc5
Compare
|
I suggested to change the DPI value because the current value is incorrect. This should be fixed ASAP because it is a bug. It's OK to leave it as I suggest, we first fix the DPI value to get correct svg images, and I work on a PR to replace the DPI values with the |
|
ping? |
|
|
||
| // UseDPI sets the dots per inch of a canvas. It should only be | ||
| // used as an option argument when initializing a new canvas. | ||
| func UseDPI(dpi int) option { |
There was a problem hiding this comment.
Let's revisit that in another issue.
This is a consequence of gonum/plot#492 bumping the DPI from 90 to 96.
This is a consequence of gonum/plot#492 bumping the DPI from 90 to 96.
This is a consequence of gonum/plot#492 bumping the DPI from 90 to 96.
Fixes #491.
Please take a look.