vg/vgsvg: make user units equivalent to points #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The font size problem could be solved if the font size is specified in user units. Currently a font size of 12pt is specified as "12pt". I suggest to specify it as "12". Logicaly it is the same since we now use points everywhere. But apparently svg makes an error when scaling the font. |
|
@sbinet ping |
sbinet
previously approved these changes
Jan 23, 2019
vg/vgsvg/vgsvg.go
Outdated
| @@ -39,7 +35,7 @@ const ( | |||
| type Canvas struct { | |||
| svg *svgo.SVG | |||
| w, h vg.Length | |||
| dpi float64 | |||
| // dpi float64 | |||
There was a problem hiding this comment.
BTW Do you know what ht is for. It is not used AFAICS.
There was a problem hiding this comment.
no idea :)
according to blame, @eaburns is the one who introduced it:
https://github.com/gonum/plot/blame/07f44254b21cff40a59809f4c926aa023286107d/vg/vgsvg/vgsvg.go
|
PTAL |
sbinet
approved these changes
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make us use points for user units, but it causes the text size to be too large.
Please take a look.
/cc @chmike