Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vgimg: translate to gg arc end point concept #527

Merged
merged 1 commit into from Feb 20, 2019
Merged

vgimg: translate to gg arc end point concept #527

merged 1 commit into from Feb 20, 2019

Conversation

kortschak
Copy link
Member

This concerts from (theta,phi) that is used by vg to (theta_1,theta_2) that is used by gg.

Please take a look.

Copy link
Member

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add a test?
LGTM

@kortschak
Copy link
Member Author

There will be tests when rings is moved to plot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants