plot: fix handling of font descents #642
Conversation
kortschak
force-pushed
the
font/descent
branch
from
00295c0
to
9888640
Compare
Codecov Report
@@ Coverage Diff @@
## master #642 +/- ##
==========================================
- Coverage 71.52% 70.28% -1.25%
==========================================
Files 55 55
Lines 5492 4620 -872
==========================================
- Hits 3928 3247 -681
+ Misses 1390 1203 -187
+ Partials 174 170 -4
Continue to review full report at Codecov.
|
| y += a.Label.Height(a.Label.Text) | ||
| y += a.Label.Padding | ||
| } | ||
|
|
||
| marks := a.Tick.Marker.Ticks(a.Min, a.Max) | ||
| ticklabelheight := tickLabelHeight(a.Tick.Label, marks) | ||
| descent := a.Tick.Label.Font.Extents().Descent |
There was a problem hiding this comment.
couldn't we move this up at line 263 and drop the line 265?
descent should be a constant for a given font.Font, right?
There was a problem hiding this comment.
L265 is for the label and L273 is for the tick label.
| @@ -372,12 +374,13 @@ func (a verticalAxis) draw(c draw.Canvas) { | |||
| } | |||
|
|
|||
| major := false | |||
| descent := a.Tick.Label.Font.Extents().Descent | |||
There was a problem hiding this comment.
ditto: perhaps move that up at ~line 355 and drop the one at line 366 ?
plot_test.go
Outdated
| got := r.Actions | ||
| c := vgimg.PngCanvas{Canvas: vgimg.New(5*vg.Centimeter, 5*vg.Centimeter)} | ||
| l.Draw(draw.New(c)) | ||
| b := bytes.NewBuffer([]byte{}) |
There was a problem hiding this comment.
| b := bytes.NewBuffer([]byte{}) | |
| b := new(bytes.Buffer) |
kortschak
force-pushed
the
font/descent
branch
from
9888640
to
0694c3f
Compare
|
PTAL |
|
This is probably worth a patch release. WDTY? |
|
Yes, I was about to suggest that as well. |
|
I'll do that tomorrow. |
|
interestingly, after updating my reference files on a Linux machine, tests failed on the Darwin machine (from Github Actions) but was ok on Windows: |
|
Font handling differences? |
|
could be, though I am using the embedded |
|
the delta is available here: the diff there: the new file here: it seems there's only one pixel difference, not involving fonts, actually... |
there's a 1-pixel difference on darwin w/ the linux generated reference plot. see: gonum/plot#642 (comment) drop the image check on darwin for that particular test. Updates go-hep#818.
Please take a look.
Fixes #294