Swift 4.2 support #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 19, 2018 17:40
|
Hi @khose. Thanks for doing this! Tests are passing and sample code works as expected. Everything looks good :) I've only found one small issue: I've Xcode set up to use tabs and you have it set up to use spaces. So code changes are not properly formatted. It is really a small issue and I can merge this PR as it is. But let me know in case you have time to fix it and I will wait for it. |
added 2 commits
December 21, 2018 12:23
khose
force-pushed
the
feature/support-swift-4.2
branch
from
eb941bd
to
b07caf7
Compare
|
Hi @gonzalezreal ! Thanks for taking a look at it. I've fixed some of them. I've changed the indentation settings, but still looks like like XCode is not helping me formatting the Tests properly. I'd appreciate if you could fix those. The rest of files seem ok now. Now a joke to finish the day :D
Again thanks for your time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to migrate Markup to Swift version 4.2.
@gonzalezreal please let me know if anything must be added to this PR