Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code duplication in usage instructions #4

Closed
gonzalo-bulnes opened this issue Oct 7, 2018 · 1 comment
Closed

Remove code duplication in usage instructions #4

gonzalo-bulnes opened this issue Oct 7, 2018 · 1 comment
Labels
good first issue Good for newcomers

Comments

@gonzalo-bulnes
Copy link
Owner

The program welcome message and instructions make extensive use of the println! macro, because they run across multiple lines, and long lines are difficult to read in the code as well.

A raw string litteral could be used instead, that would:

  • keep the message readable in the code
  • keep the message formatting unchanged in the program output
  • require only one println! : )

Note: I'd like to add some tests around this to make the refactoring easier, but I'll be more than happy to accept a contribution based on manual testing if I haven't added them when you pick it up!

@gonzalo-bulnes gonzalo-bulnes added the good first issue Good for newcomers label Oct 7, 2018
@gonzalo-bulnes gonzalo-bulnes added help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Oct 7, 2018
@Bassetts
Copy link
Contributor

Bassetts commented Oct 8, 2018

I'd like to pick this up please 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants