Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove rails dependency #3

Closed
aaronchi opened this issue Dec 16, 2013 · 1 comment
Closed

remove rails dependency #3

aaronchi opened this issue Dec 16, 2013 · 1 comment
Labels
bug
Milestone
v1.0.0

Comments

@aaronchi
Copy link

Devise already defines a railties dependency. The current rails dependency in this gem prevents you from installing this on rails 3.2
gonzalo-bulnes added a commit that referenced this issue Dec 16, 2013
@gonzalo-bulnes
Remove Rails dependency, delegate it to Devise
ad2dd83 
Fix #3
gonzalo-bulnes added a commit that referenced this issue Dec 17, 2013
@gonzalo-bulnes
Fix redundant Rails dependency, delegate to Devise
54ec9db 
I removed any non-critical Rails-related dependencies and
aligned version requirements to Devise ones.

Fixes #3
@gonzalo-bulnes
Copy link
Owner

Sorry for the repetitions, I first didn't notice activerecord and activemailer dependencies needed to be delaclared in spite of devise.

@aaronchi Your comment makes sense to me, please report here any issue you could find using Rails 3.2. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
2 participants
@aaronchi @gonzalo-bulnes