Skip to content

Commit

Permalink
Add post-mortem catch around failed transport addr binds to aid with …
Browse files Browse the repository at this point in the history
…runtime debugging
  • Loading branch information
goodboy committed Oct 3, 2023
1 parent e94f126 commit 4314a59
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 10 deletions.
12 changes: 8 additions & 4 deletions tractor/_root.py
Expand Up @@ -260,10 +260,14 @@ async def ping_tpt_socket(
# start the actor runtime in a new task
async with trio.open_nursery() as nursery:

# ``_runtime.async_main()`` creates an internal nursery and
# thus blocks here until the entire underlying actor tree has
# terminated thereby conducting structured concurrency.

# ``_runtime.async_main()`` creates an internal nursery
# and blocks here until any underlying actor(-process)
# tree has terminated thereby conducting so called
# "end-to-end" structured concurrency throughout an
# entire hierarchical python sub-process set; all
# "actor runtime" primitives are SC-compat and thus all
# transitively spawned actors/processes must be as
# well.
await nursery.start(
partial(
async_main,
Expand Down
21 changes: 15 additions & 6 deletions tractor/_runtime.py
Expand Up @@ -1405,13 +1405,22 @@ async def async_main(
# - root actor: the ``accept_addr`` passed to this method
assert accept_addrs

actor._server_n = await service_nursery.start(
partial(
actor._serve_forever,
service_nursery,
listen_sockaddrs=accept_addrs,
try:
actor._server_n = await service_nursery.start(
partial(
actor._serve_forever,
service_nursery,
listen_sockaddrs=accept_addrs,
)
)
)
except OSError as oserr:
# NOTE: always allow runtime hackers to debug
# tranport address bind errors - normally it's
# something silly like the wrong socket-address
# passed via a config or CLI Bo
entered_debug = await _debug._maybe_enter_pm(oserr)
raise

accept_addrs: list[tuple[str, int]] = actor.accept_addrs

# NOTE: only set the loopback addr for the
Expand Down

0 comments on commit 4314a59

Please sign in to comment.