Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use clean channel shutdown in streaming example #65

Closed
goodboy opened this issue Mar 10, 2019 · 0 comments · Fixed by #68
Closed

Use clean channel shutdown in streaming example #65

goodboy opened this issue Mar 10, 2019 · 0 comments · Fixed by #68
Labels
docs enhancement New feature or request

Comments

@goodboy
Copy link
Owner

goodboy commented Mar 10, 2019

Thanks again to @parity3 for pointing this out.

Instead of using None sentinel to terminate the mult-task aggregator loops we should instead use the new clean channel shutdown async with api.

We need to change the test as well.
@goodboy goodboy added enhancement New feature or request docs labels Mar 10, 2019
goodboy pushed a commit that referenced this issue Mar 10, 2019
Use "clean channel shutdown" in streaming example
6b83c9f 
WIP on try to solve #65
This is currently failing due to deadlock.
@goodboy goodboy mentioned this issue Mar 10, 2019
Merged
goodboy pushed a commit that referenced this issue Mar 11, 2019
Use "clean channel shutdown" in streaming example
9a78048 
Resolves #65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use "clean channel shutdown" in streaming example goodboy/tractor
1 participant
@goodboy