End the pdb SIGINT handling madness
#170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out this is a lower level issue in terms of the stdlib's default `pdb.Pdb` settings and how they conflict with `trio`s cancellation and KBI handling. The details are hashed out more thoroughly in python-trio/trio#1155. Maybe we can get a fix in trio so things are solved under our feet :)
goodboy
commented
Dec 12, 2020
| actor, main, host, port, arbiter_addr=arbiter_addr | ||
| ) | ||
| finally: | ||
| logger.info("Root actor terminated") |
There was a problem hiding this comment.
These are probably superfluous (and maybe should be .debug()) but figured can't hurt atm. Likely we'll throttle back logging noise before first .dev0.
goodboy
commented
Dec 12, 2020
| self._listeners.extend(listeners) | ||
| log.debug( | ||
| "Started tcp server(s) on" | ||
| f" {[getattr(l, 'socket', 'unknown socket') for l in l]}") |
There was a problem hiding this comment.
just mypy stuff since technically .socket isn't discovered through the type system easily.
goodboy
commented
Dec 12, 2020
| @@ -132,19 +130,6 @@ async def _acquire_debug_lock(uid: Tuple[str, str]) -> AsyncIterator[None]: | |||
| log.error(f"TTY lock released by {task_name}:{uid}") | |||
|
|
|||
|
|
|||
| def handler(signum, frame): | |||
There was a problem hiding this comment.
Turns out we can just keep trio standard KBI handling as long as we prevent pdb.Pdb from overriding it!
goodboy
commented
Dec 12, 2020
| # critical to having ctrl-c work in the ``trio`` standard way! | ||
| # The stdlib's pdb supports entering the current sync frame | ||
| # on a SIGINT, with ``trio`` we pretty much never want this | ||
| # and we did we can handle it in the ``tractor`` task runtime. |
There was a problem hiding this comment.
should be and if we did..
guilledk
approved these changes
Dec 12, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out this is a lower level issue in terms of the stdlib's default
pdb.Pdbsettings and how they conflict withtrios cancellation andKBI handling. The details are hashed out more thoroughly in
python-trio/trio#1155. Maybe we can get a fix in trio so things are
solved under our feet :)