Drop sync func invocation support. #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a sync method that can be used to cancel the current actor from a synchronous context. This is useful in debugging situations where sync debugger code may need to kill the process tree. Also, make the internal "lifetime stack" a global var; easier to manage from client code that may was to add callbacks prior to the actor runtime being fully setup.
goodboy
force-pushed
the
drop_sync_funcs
branch
from
340f44c
to
9e005f7
Compare
You can always wrap a sync function in an async one and there seems to be no good reason to support invoking them directly especially since cancellation won't work without some thread hackery. If it's requested we'll point users to `trio-parallel`. Resolves #77
goodboy
force-pushed
the
drop_sync_funcs
branch
from
9e005f7
to
d0eacc3
Compare
|
@richardsheridan if there's any other pointers you'd want us to have to your repo just say the word. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #77.
Realized we had a bunch of arbiter methods that were sync and of course now the concurrent primes example function needs to be async. Looks a little unwelcoming imo but then again if peeps are here and don't want to make everything
asyncmaybe it's the wrong spot 馃槀Also, as mentioned in the readme,
trio-parallelfor anyone who wants the sync func support.