Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mp teardown hardening #208

Merged
merged 4 commits into from
May 6, 2021
Merged

Mp teardown hardening #208

merged 4 commits into from
May 6, 2021

Commits on May 6, 2021

  1. Distinctly separate and harden mp spawning 

    It's clear now that special attention is needed to handle the case where
a spawned `multiprocessing` proc is started but then the parent is
cancelled before the child can connect back; in this case we need to be
sure to kill the near-zombie child asap. This may end up being the
solution to other resiliency issues seen around mp with nested process
trees too. More testing is needed to be sure.

Relates to #84 #89 #134 #146
    @goodboy
    goodboy committed May 6, 2021
    Configuration menu
    Copy the full SHA
    607c48f View commit details
    Browse the repository at this point in the history

  2. Shield around root actor cancel

    @goodboy
    goodboy committed May 6, 2021
    Configuration menu
    Copy the full SHA
    c4b4200 View commit details
    Browse the repository at this point in the history

  3. Appease mypy

    @goodboy
    goodboy committed May 6, 2021
    Configuration menu
    Copy the full SHA
    9f38406 View commit details
    Browse the repository at this point in the history

  4. Re-raise any sidestepped trio.Cancelled

    @goodboy
    goodboy committed May 6, 2021
    Configuration menu
    Copy the full SHA
    87971de View commit details
    Browse the repository at this point in the history