Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExceptiongGroups and trio>=0.22 #333

Merged
merged 20 commits into from
Oct 15, 2022
Merged

ExceptiongGroups and trio>=0.22 #333

merged 20 commits into from
Oct 15, 2022

Commits on Oct 12, 2022

  1. Configuration menu
    Copy the full SHA
    98056f6 View commit details
    Browse the repository at this point in the history
  2. Adjust "no arbiter" test for new runtime defaults

    Turns out this test was being silently ignored due to incorrect usage of
    sync opening of our `.open_nursery()` block (with a `with` not `async
    with`) and thus was an noop XD
    
    Instead this fixes the test to call a `tractor` discovery built-in
    without starting the runtime (which is now done implicitly when a user
    opens a nursery) which should result in the prior expected outcome,
    a `RuntimeError`.
    goodboy committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    b15e4ed View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. Pin to latest trio version

    goodboy committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    df69aed View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d87d6af View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    50fe098 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0f523b6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7521bde View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    33f2234 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c646c79 View commit details
    Browse the repository at this point in the history
  8. Restore the trio SIGINT handler, cancel root lock tasks on no-peers

    Pretty sure this is the final touch to alleviate all our debug lock
    headaches! Instead of trying to revert to the "last" handler (as `pdb`
    does internally in the stdlib) we always just revert to the handler
    `trio` registers during startup. Further this seems to allow cancelling
    the root-side locking task if it's detected as stale IFF we only do this
    when the root actor is in a "no more IPC peers" state.
    
    Deatz:
    - (always) set `._debug.Lock._trio_handler` as the `trio` version, not
      some last used handler to make sure we're getting the ctrl-c handling
      we want when not in debug mode.
    - assign the trio handler in `open_root_actor()`
      `._runtime._async_main()` to be sure it's applied in subactors as well
      as the root.
    - only do debug lock blocking and root-side-locking-task cancels when
      a "no peers" condition is detected in the root actor: i.e. no IPC
      channels are detected by the root meaning it's impossible any actor
      has a sane lock-state ongoing for debug mode.
    goodboy committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    0956d5f View commit details
    Browse the repository at this point in the history
  9. Fix handler type annot

    goodboy committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    88448f7 View commit details
    Browse the repository at this point in the history
  10. Fix errors table type annot

    goodboy committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    38f9d35 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    347591c View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    c0dd5d7 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    e298b70 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    0a1bf8e View commit details
    Browse the repository at this point in the history
  15. Drop error-repacking for .run_in_actor()s block

    If we pack the nursery parent task's error into the `errors` table
    directly in the handler, we don't need to specially handle packing that
    same error into any exception group raised while handling sub-actor
    cancellation; drops some ugly indentation ;)
    goodboy committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    f39414c View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    c475759 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    f2641c8 View commit details
    Browse the repository at this point in the history
  18. Add nooz

    goodboy committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    274c66c View commit details
    Browse the repository at this point in the history