-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExceptiongGroup
s and trio>=0.22
#333
Merged
Merged
Commits on Oct 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 98056f6 - Browse repository at this point
Copy the full SHA 98056f6View commit details -
Adjust "no arbiter" test for new runtime defaults
Turns out this test was being silently ignored due to incorrect usage of sync opening of our `.open_nursery()` block (with a `with` not `async with`) and thus was an noop XD Instead this fixes the test to call a `tractor` discovery built-in without starting the runtime (which is now done implicitly when a user opens a nursery) which should result in the prior expected outcome, a `RuntimeError`.
Configuration menu - View commit details
-
Copy full SHA for b15e4ed - Browse repository at this point
Copy the full SHA b15e4edView commit details
Commits on Oct 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for df69aed - Browse repository at this point
Copy the full SHA df69aedView commit details -
Configuration menu - View commit details
-
Copy full SHA for d87d6af - Browse repository at this point
Copy the full SHA d87d6afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 50fe098 - Browse repository at this point
Copy the full SHA 50fe098View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f523b6 - Browse repository at this point
Copy the full SHA 0f523b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7521bde - Browse repository at this point
Copy the full SHA 7521bdeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 33f2234 - Browse repository at this point
Copy the full SHA 33f2234View commit details -
Configuration menu - View commit details
-
Copy full SHA for c646c79 - Browse repository at this point
Copy the full SHA c646c79View commit details -
Restore the
trio
SIGINT handler, cancel root lock tasks on no-peersPretty sure this is the final touch to alleviate all our debug lock headaches! Instead of trying to revert to the "last" handler (as `pdb` does internally in the stdlib) we always just revert to the handler `trio` registers during startup. Further this seems to allow cancelling the root-side locking task if it's detected as stale IFF we only do this when the root actor is in a "no more IPC peers" state. Deatz: - (always) set `._debug.Lock._trio_handler` as the `trio` version, not some last used handler to make sure we're getting the ctrl-c handling we want when not in debug mode. - assign the trio handler in `open_root_actor()` `._runtime._async_main()` to be sure it's applied in subactors as well as the root. - only do debug lock blocking and root-side-locking-task cancels when a "no peers" condition is detected in the root actor: i.e. no IPC channels are detected by the root meaning it's impossible any actor has a sane lock-state ongoing for debug mode.
Configuration menu - View commit details
-
Copy full SHA for 0956d5f - Browse repository at this point
Copy the full SHA 0956d5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 88448f7 - Browse repository at this point
Copy the full SHA 88448f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 38f9d35 - Browse repository at this point
Copy the full SHA 38f9d35View commit details -
Configuration menu - View commit details
-
Copy full SHA for 347591c - Browse repository at this point
Copy the full SHA 347591cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c0dd5d7 - Browse repository at this point
Copy the full SHA c0dd5d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for e298b70 - Browse repository at this point
Copy the full SHA e298b70View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a1bf8e - Browse repository at this point
Copy the full SHA 0a1bf8eView commit details -
Drop error-repacking for
.run_in_actor()
s blockIf we pack the nursery parent task's error into the `errors` table directly in the handler, we don't need to specially handle packing that same error into any exception group raised while handling sub-actor cancellation; drops some ugly indentation ;)
Configuration menu - View commit details
-
Copy full SHA for f39414c - Browse repository at this point
Copy the full SHA f39414cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c475759 - Browse repository at this point
Copy the full SHA c475759View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2641c8 - Browse repository at this point
Copy the full SHA f2641c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 274c66c - Browse repository at this point
Copy the full SHA 274c66cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.