Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context semantics for cross-actor-task cancellation and overruns #357

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

Context semantics for cross-actor-task cancellation and overruns #357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
cfb2bc0
Enable `Context` backpressure by default; avoid startup race-crashes?
goodboy Mar 7, 2023
d753431
More single doc-strs in discovery mod
goodboy Mar 7, 2023
903537c
Tweak context doc str
goodboy Apr 2, 2023
b3f9251
Add some log-level method doc-strings
goodboy Apr 4, 2023
e80e0a5
Change a bunch of log levels to cancel, including any `ContextCancell…
goodboy Apr 7, 2023
8317903
Assign `RemoteActorError` boxed error type for context cancelleds
goodboy Apr 7, 2023
220b244
Log waiter task cancelling msg as cancel-level
goodboy Apr 7, 2023
71cd445
Add new set of context cancellation tests
goodboy Apr 12, 2023
67f82c6
Add new remote error introspection attrs
goodboy Apr 12, 2023
03644f5
Augment test cases for callee-returns-result early
goodboy Apr 13, 2023
f54c415
Move `NoRuntime` import inside `current_actor()` to avoid cycle
goodboy Apr 13, 2023
90e4101
Only tuplize `.canceller` if non-`None`
goodboy Apr 13, 2023
c720260
Remote `Context` cancellation semantics rework B)
goodboy Apr 13, 2023
6994d20
Drop brackpressure usage from fan out tests
goodboy Apr 13, 2023
6db656f
Flip allocate log msgs to debug
goodboy Apr 13, 2023
f1e9c0b
Fix cluster test to use `allow_overruns`
goodboy Apr 13, 2023
63adf73
Adjust aio test for silent cancellation by parent
goodboy Apr 13, 2023
f9911c2
Seriously cover all overrun cases
goodboy Apr 13, 2023
968f13f
Set `Context._scope_nursery` on callee side too
goodboy Apr 14, 2023
04e4397
Ignore drainer-task nursery RTE during context exit
goodboy Apr 14, 2023
041d7da
Drop caller cancels overrun test; covered in new tests
goodboy Apr 14, 2023
20d75ff
Move move context code into new `._context` mod
goodboy Apr 14, 2023
7293b82
Tweak doc string
goodboy Apr 14, 2023
60791ed
Oof, fix remaining `Actor.cancel()` in `Actor._from_parent()`
goodboy Apr 20, 2023
ead9e41
Expose `allow_overruns` to `Portal.open_context()`
goodboy May 12, 2023
a0276f4
Remote cancellation runtime-internal vars renames
goodboy May 18, 2023
6495688
Drop `Optional` style from runtime mod
goodboy May 25, 2023
17ae449
Tidy up `typing` imports in broadcaster mod
goodboy Jun 14, 2023
7507e26
Just import `mp` top level in `._spawn`
goodboy Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/test_clustering.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ async def worker(
await ctx.started()

async with ctx.open_stream(
backpressure=True,
allow_overruns=True,
) as stream:

# TODO: this with the below assert causes a hang bug?
Expand Down