Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fix: CSV exporter cant's output multiple line columns #11

Merged
merged 1 commit into from
Dec 22, 2012
Merged

bug fix: CSV exporter cant's output multiple line columns #11

merged 1 commit into from
Dec 22, 2012

Conversation

suin
Copy link
Member

@suin suin commented Dec 22, 2012

How to reproduce

$config = new ExporterConfig();
$exporter = new Exporter($config);

$exporter->export($csv, array(
    array("line1\r\nline2\r\nline3"),
    array("line1\r\nline2\r\nline3"),
    array("line1\r\nline2\r\nline3"),
));

Expected CSV Output

"line1
line2
line3"
"line1
line2
line3"
"line1
line2
line3"

Actual Behavior

"line1
"line1
"line1

@suin suin mentioned this pull request Dec 22, 2012
Closed
suin added a commit that referenced this pull request Dec 22, 2012
@suin
Merge pull request #11 from goodby/feature/support-multiline-columns
3ddc355 
bug fix: CSV exporter cant's output multiple line columns
@suin suin merged commit 3ddc355 into master Dec 22, 2012
@suin suin deleted the feature/support-multiline-columns branch December 22, 2012 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.1
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@suin