-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
translate qiskit.QuantumCircuit to Circuit #203
translate qiskit.QuantumCircuit to Circuit #203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the functionality is there, thank you ! I think we need to change a few things however.
Can I please ask you to add a "performance test" (similar to what we did in https://github.com/goodchemistryco/Tangelo/blob/main/tangelo/linq/tests/test_translator_qubitop.py) to check how much time each direction take for a decently large quantum circuit. You can generate an arbitrary quantum circuit with a relevant size (100K gates?) and maybe time both ways.
As long as the test takes less than 30 secs it can be included inautomated tests, otherwise we can unittest.skip
it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff, a few small comments (some related to old docstrings that have not aged too well, oops). Should be quick to handle
8ef1793
to
70fdc70
Compare
* Formula for estimating n_measurements for exp value to given accuracy updated with simpler form. (#192) * Fix operator_expectation bug qith qubit operator / hamiltonian. (#191) * iqcc ilc solver fork (#179) * Make circuit iterable (#194) * copy method for circuits + get_resources adjusted for some variations of VQE + invertible swap gate fix (#193) * Release guide for project maintainers + version string (#195) * Notebook: Important aspects of QChem modelling for QComputing (#199) * Notebooks enabled for Google colab ("No local install" needed) (#198) * Docker fix (#200) * Excited states (#197) * Translation function for qubit operators (#196) * c2v axis definition changed (#205) * Bidirectional conversion for Qiskit quantum circuits (#203) * QEMISTClientConnection class (#207) * Add n_qubits option to MultiformOperator compress function (#209) * Quantum Signal Processing time-evolution (#204) * added even trotter order > 2 (#210) * Fixed number of qubits with scBK in ADAPT. (#214) * Export coverage output file in github actions (#158) * JKMN vector prep should return np array of int. (#215) * Support for additional IonQ gates (#212) * Remove unused n_min_orbitals attribute. (#218) * Change JKMN Majorana definition so mapped Hamiltonian is real (#219) * Relaxing condition fot iQCC-ILC test. (#221) * Histogram class (#217) * Compute energy from RDMs with FermionOperator (#220) * IonQConnection: control update prints / verbosity. (#225) * Refactor simulator (#213) * added __repr__ method to Gate (#229) * New bidirectional circuit translation functions and interface (#223) * Add circuit.depth() in get_resources methods (#235) * Variance and standard error of an expectation value (#238) * VQESolver cleanup (#230) * TETRIS-ADAPT-VQE (#241) * TETRISADAPTSolver implementation + #224 fix * Trotter order and active electrons for (i)QCC (#234) * Symmetry post-selection (#232) * Qiskit runtime integration (IBM quantum only) (#222) * Add multi-control support for trotterization (#244) * Compatibility with new QCloud outputs. (#246) * Deprecate Simulator, introduce get_backend as replacement (#245) * compute_rdms function (#228) * Expanded FermionOperator attributes, defined logical and mathematical operations on it (add, mul, eq, etc) * Bumping Tangelo version number in _version.py * Update CHANGELOG.md Co-authored-by: Valentin Senicourt <41597680+ValentinS4t1qbit@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: AlexandreF-1qbit <76115575+AlexandreF-1qbit@users.noreply.github.com> Co-authored-by: James Brown <james.brown@1qbit.com> Co-authored-by: JamesB-1qbit <84878946+JamesB-1qbit@users.noreply.github.com> Co-authored-by: MPCoons <84400409+MPCoons@users.noreply.github.com> Co-authored-by: elloyd-1qbit <58313607+elloyd-1qbit@users.noreply.github.com> Co-authored-by: KrzysztofB-1qbit <86750444+KrzysztofB-1qbit@users.noreply.github.com> Co-authored-by: Rudi Plesch <rudi.plesch@1qbit.com> Co-authored-by: GitHub Actions <noreply@github.com> Co-authored-by: Valentin Senicourt <valentin.senicourt@1qbit.com> Co-authored-by: Joshua Goings <3915169+jjgoings@users.noreply.github.com>
Change
translate_qiskit
such that a qiskit.QuantumCircuit with supported gates can be translated to Circuit format.