including terminal-table breaks activerecord queries

[desheikh]

As referenced in tj/terminal-table#47, terminal-table monkeypatches the ruby String class, which breaks activerecord queries. This prevents us from using gooddata-ruby in our rails app.

[fluke777]

Hey @desheikh sorry for later response. This is unfortunate. I see no response from terminal-table team. We are currently working on fixing some smaller issues. We will let you know how we decide about proceeding. By any chance do you understand the reason why they alias String#ljust, to left?

[desheikh]

Hi @fluke777, the alias just seems to be for cosmetic reasons, the fix seems pretty simple but I haven't been able to get the test suite to run though.

I'm working off a fork which removes the cli dependencies for now. It feels that functionality could really just be split off to a separate gem.

[fluke777]

@desheikh Comsetic reasons are the worst :-) We can prepare the fix the question is if the author will merge it. Worst case we will remove the dependency. Hopefully there is something out there that does something similar.

[nateberkopec]

This is fixed on master in terminal-table. I should have a release out soon.

[korczis]

@nateberkopec Thank you for info, do you have any idea when new version could get released?

[korczis]

Related to tj/terminal-table#45

[nateberkopec]

Sorry, I don't - what you see in that issue thread is all I know.

[fluke777]

I am closing this. We updated to the latest version recently. Thanks everybody who helped to get the new release of terminal-table out.

[nateberkopec]

🎉