Refactor, fix synchronous interface #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 13, 2015 16:18
…to factoryFn, can introspect.
(@demands, how's this supposed to work w/o fibrous? thanks!)
benbuckman
added a commit
that referenced
this pull request
May 14, 2015
Refactor, fix synchronous interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bunch of bugs in unionized and unionized-mongoose.
Hopefully the sync vs async interfaces are clearer now.
(In retrospect, we should never have introduced the sync interface, but it's there now, so...)
Several features – in particular
embedArray– still only work with fibrous (and/or their interface with fibrous is very confusing). #6 remains open.Will bump a major version because the interface changed a little.