fix hostsperline to 9 #17
Conversation
Windows does not support more than 9 hosts per line
|
this already happens with this https://github.com/goodhosts/hostsfile/blob/master/const_windows.go#L5 |
|
@luthermonson where is that applied though? We were dealing with a user that had 16 entries on a single line |
|
it's compiled into the windows executable via build flags. it should be the default. did you try your fix and did it fix it? because it should be the exact same value/logic and if its doing 16 before it will do 16 after your change. basically the logic is these build tags here https://github.com/goodhosts/hostsfile/blob/master/const.go#L1 says this is for anything not windows so windows has it's own consts... this works cause we know the hosts file location changes and it finds the system32/drivers/etc/hosts file |
| @@ -120,6 +120,7 @@ func (h *Hosts) Add(ip string, hosts ...string) error { | |||
| } | |||
| h.Lines[position].Hosts = hostsCopy | |||
| h.Lines[position].Raw = h.Lines[position].ToRaw() // reset raw | |||
| h.HostsPerLine(9) // make sure this does not break on Windows | |||
There was a problem hiding this comment.
@luthermonson is the actual fix that this line should be added but that it shouldn't be hardcoded to 9?
Windows does not support more than 9 hosts per line