Disable RSpec/LetSetup by default. Close rubocop#887

goodniceweb · Mar 26, 2020 · a4ed175 · a4ed175
1 parent 8c6af61
commit a4ed175
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 * Fix `RSpec/FilePath` detection when absolute path includes test subject. ([@eitoball][])
 * Add new `Capybara/VisibilityMatcher` cop. ([@aried3r][])
+* Disable `RSpec/LetSetup` cop in the default configuration. ([@goodniceweb][])
 
 ## 1.38.1 (2020-02-15)
 
@@ -494,3 +495,4 @@ Compatibility release so users can upgrade RuboCop to 0.51.0. No new features.
 [@elebow]: https://github.com/elebow
 [@eitoball]: https://github.com/eitoball
 [@aried3r]: https://github.com/aried3r
+[@goodniceweb]: https://github.com/goodniceweb
diff --git a/config/default.yml b/config/default.yml
@@ -284,7 +284,7 @@ RSpec/LetBeforeExamples:
 
 RSpec/LetSetup:
   Description: Checks unreferenced `let!` calls being used for test setup.
-  Enabled: true
+  Enabled: false
   StyleGuide: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/LetSetup
 
 RSpec/MessageChain:

diff --git a/manual/cops_rspec.md b/manual/cops_rspec.md
@@ -1802,7 +1802,7 @@ end
 
 Enabled by default | Supports autocorrection
 --- | ---
-Enabled | No
+Disabled | No
 
 Checks unreferenced `let!` calls being used for test setup.