Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Record the operator who deleted the build version #1378

Merged
merged 1 commit into from
Aug 11, 2023
Merged

fix: Record the operator who deleted the build version #1378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion console/views/service_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,9 @@ def delete(self, request, *args, **kwargs):
version_id = kwargs.get("version_id", None)
if not version_id:
return Response(general_message(400, "attr_name not specify", "请指定需要删除的具体版本"))
body = {"operator": str(self.user.nick_name)}
region_api.delete_service_build_version(self.response_region, self.tenant.tenant_name, self.service.service_alias,
version_id)
version_id, body)
# event_repo.delete_event_by_build_version(self.service.service_id, version_id)
result = general_message(200, "success", "删除成功")
return Response(result, status=result["code"])
Expand Down
4 changes: 2 additions & 2 deletions www/apiclient/regionapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1563,7 +1563,7 @@ def get_service_build_versions(self, region, tenant_name, service_alias):
res, body = self._get(url, self.default_headers, region=region)
return body

def delete_service_build_version(self, region, tenant_name, service_alias, version_id):
def delete_service_build_version(self, region, tenant_name, service_alias, version_id, body):
"""删除组件的某次构建版本"""

url, token = self.__get_region_access_info(tenant_name, region)
Expand All @@ -1572,7 +1572,7 @@ def delete_service_build_version(self, region, tenant_name, service_alias, versi
+ service_alias + "/build-version/" + version_id

self._set_headers(token)
res, body = self._delete(url, self.default_headers, region=region)
res, body = self._delete(url, self.default_headers, region=region, body=json.dumps(body))
return body

def get_service_build_version_by_id(self, region, tenant_name, service_alias, version_id):
Expand Down
Loading