Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acme Tutorial Won't Start in Colab #14

Closed
mosicr opened this issue Jun 9, 2020 · 3 comments
Closed

Acme Tutorial Won't Start in Colab #14

mosicr opened this issue Jun 9, 2020 · 3 comments

Comments

@mosicr
Copy link

mosicr commented Jun 9, 2020

Hi,
https://github.com/deepmind/acme/blob/master/examples/tutorial.ipynb
won't start in Colab. , if ran manually it fails on cell 2 with:
File "", line 32
except ModuleNotFoundError, OSError:
^
SyntaxError: invalid syntax
Moreover, the Acme paper is full of typos and mistakes.

@mosicr
Copy link
Author

mosicr commented Jun 10, 2020

Now it does open in Colab, but still fails with the above error.

@aslanides
Copy link
Member

Hey mate. Thanks for pointing this out. Looking into it now :)

@aslanides aslanides changed the title Very buggy: Acme Tutorial Won't Start in Colab Acme Tutorial Won't Start in Colab Jun 10, 2020
@aslanides
Copy link
Member

I've made a fix which will get pushed in the next few minutes.

FWIW, our CI doesn't cover the colabs, so this is something we could improve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants