Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering atari environment #26

Closed
dcharrezt opened this issue Jun 14, 2020 · 4 comments
Closed

Rendering atari environment #26

dcharrezt opened this issue Jun 14, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@dcharrezt
Copy link

Hi, thanks for open sourcing this framework

I was trying to visualize what the agent has learned, but I could not render the atari environment.

After the GymAtariAdapter wrapper is used when I try to render the environment I get

AttributeError: 'AtariWrapper' object has no attribute 'render'

And I can not unwrap it either

'AtariWrapper' object has no attribute 'unwrapped'

I apologize if this is the intended behavior.

@bshahr
Copy link
Collaborator

bshahr commented Jun 15, 2020

Hi dcharrezt,
Thanks for pointing this out! It seems we don't have a public pointer to the unwrapped environment. For now you can use AtariWrapper._environment, we'll try to fix this soon.

@aslanides aslanides added the enhancement New feature or request label Jun 18, 2020
@bshahr
Copy link
Collaborator

bshahr commented Jun 19, 2020

This actually may be as simple as making AtariWrapper inherit from acme.wrappers.base.EnvironmentWrapper, then you'll have access to the unwrapped environment via the unprotected EnvironmentWrapper.environment instead. Can anyone confirm that this doesn't have any unwanted side effects? Otherwise I'll try to look into this next week.

@TheSnowGuru
Copy link

Hey guys, I created a discord for this project to be able to better contribute to the issues,share training results and more, enjoy.
https://discord.gg/Rf6EU7

copybara-service bot pushed a commit that referenced this issue Jun 25, 2020
Resolves issue #26.

PiperOrigin-RevId: 318244490
Change-Id: Id2e37e2d2032e738f97e45939cf2d2ed9b73d9b7
@aslanides
Copy link
Member

This should be resolved now. Let me know if you have any other issues.

alex-gran23 pushed a commit to Next-Step-Fusion/acme that referenced this issue Feb 23, 2024
Resolves issue google-deepmind#26.

PiperOrigin-RevId: 318244490
Change-Id: Id2e37e2d2032e738f97e45939cf2d2ed9b73d9b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants