Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ER sampling for undirected graphs #9

Closed
wants to merge 1 commit into from
Closed

Fix ER sampling for undirected graphs #9

wants to merge 1 commit into from

Conversation

smahdavi4
Copy link

Hi, I think there is a small issue in the implementation of ER sampling for undirected graphs. With current implementation, each edge is present if both of its directions are present, whose probability would be p^2. Also for self-loops, the probability is p. To make it more consistent with ER graph generation, I think each undirected edge should be sampled with probability p (instead of p^2).

@PetarV-
Copy link
Collaborator

PetarV- commented Dec 20, 2021

Thank you for noting this!
For the next version of the library, we will decide if it is better to incorporate the pull request, or to leave a descriptive comment about the behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants