Fix ER sampling for undirected graphs #9
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I think there is a small issue in the implementation of ER sampling for undirected graphs. With current implementation, each edge is present if both of its directions are present, whose probability would be
p^2
. Also for self-loops, the probability isp
. To make it more consistent with ER graph generation, I think each undirected edge should be sampled with probabilityp
(instead ofp^2
).