Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added interactive examples of PIX Augmentations with Google Colab #26

Merged
merged 7 commits into from
Dec 27, 2021

Conversation

SupreethRao99
Copy link
Contributor

Added interactive examples of running every augmentation in the pix library on a Google Colab notebook which can be found here.

@claudiofantacci
Copy link
Collaborator

Hey @SupreethRao99, thanks for the PR.
It LGTM, however I would prefer to have the ipynb directly under /example folder as image_augmentation.ipynb.
Then you can update the link to point to that file 😄

@SupreethRao99
Copy link
Contributor Author

Hey @claudiofantacci I've renamed the file to image_augmentation.ipynb and saved it under /examples as requested. The link the notebook will remain the same.

Could you take a look and tell me if any other changes need to be made? Thank you !

@@ -13,3 +13,4 @@ Then, to run the examples, you can simply run the following commands:
$ cd examples/
$ python image_augmentation.py
```
You can also view an interactive version of the examples on [google colab](https://colab.research.google.com/drive/1EJG6VNhH5aJNy9sT7jUQkgYP5GeGPUvw?usp=sharing)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change [google colab](https://colab.research.google.com/drive/1EJG6VNhH5aJNy9sT7jUQkgYP5GeGPUvw?usp=sharing) to [Colab](./image_augmentation.ipynb)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ill change it right away

@claudiofantacci
Copy link
Collaborator

Hey @SupreethRao99 thanks a lot again!
Please also update the link to point to the internal ipynb, which would make the repo self-contained 😄

updated link to image augmentation Google Colab notebook
examples/README.md Outdated Show resolved Hide resolved
Corrected a errors and typos
Copy link
Collaborator

@claudiofantacci claudiofantacci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for contributing!

Copy link
Collaborator

@claudiofantacci claudiofantacci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @SupreethRao99 could you please open for edit image_augmentation.ipynb with any text editor and add a single empty line at the bottom of the file?

Added single empty line at the end the notebook
@SupreethRao99
Copy link
Contributor Author

Hey, @claudiofantacci I've added a single empty line at the end of image_augmentation.ipynb.

@claudiofantacci
Copy link
Collaborator

The PR will be automatically merged by Copybara automatically. This may take a while, sorry about that 😄
If anything goes wrong, I'll let you know!
In the meantime @SupreethRao99 thanks again for the contribution 🚀

@SupreethRao99
Copy link
Contributor Author

Thank you ! @claudiofantacci

copybara-service bot pushed a commit that referenced this pull request Dec 27, 2021
FUTURE_COPYBARA_INTEGRATE_REVIEW=#26 from SupreethRao99:master a060f0c
PiperOrigin-RevId: 418465644
@copybara-service copybara-service bot mentioned this pull request Dec 27, 2021
copybara-service bot pushed a commit that referenced this pull request Dec 27, 2021
FUTURE_COPYBARA_INTEGRATE_REVIEW=#26 from SupreethRao99:master a060f0c
PiperOrigin-RevId: 418465644
copybara-service bot pushed a commit that referenced this pull request Dec 27, 2021
FUTURE_COPYBARA_INTEGRATE_REVIEW=#26 from SupreethRao99:master a060f0c
PiperOrigin-RevId: 418465644
copybara-service bot pushed a commit that referenced this pull request Dec 27, 2021
FUTURE_COPYBARA_INTEGRATE_REVIEW=#26 from SupreethRao99:master a060f0c
PiperOrigin-RevId: 418465644
@copybara-service copybara-service bot merged commit d36053f into google-deepmind:master Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants