Fixed a problem with linking the math library on ubuntu 14.04 and 16.04 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkoeppe
reviewed
Dec 20, 2016
| @@ -537,7 +537,7 @@ cc_binary( | |||
| "-DQDECL=", | |||
| "-pthread", | |||
| ], | |||
| linkopts = ["-pthread"], | |||
| linkopts = ["-pthread", "-lm"], | |||
There was a problem hiding this comment.
Please keep each list item on a separate line. (See how the rest of the file is formatted.)
|
Thanks, I will include this change in a pending update. |
Closed
tkoeppe
added a commit
that referenced
this pull request
Dec 20, 2016
This change was suggested in #12; this commit formats the change slightly differently. PiperOrigin-RevId: 142557801
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #6.
It now works on both 14.04 and 16.04.
Math libraries were not properly linked in both :game and :bspc.