Add experimental python 3 support #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm that cloning this repo allowed me to run deepmind lab random_agent with python3 |
Merge with deepmind/lab master
tkoeppe
force-pushed
the
master
branch
2 times, most recently
from
31fe629
to
87f8993
Compare
|
I'll try to take a stab at getting the same code to work in Py2 and Py3. That would be a viable outcome. |
|
I pushed an update to the native module code via b01c3d6. Feel free to rebase; hopefully this will simplify your approach a little. |
|
Have a look at 3fd8582. I think it should be possible to use Python 2 and 3 now, and with a bit of effort, even on the same Python code. Check out the Bazel attributes related to choosing a Python version, too: https://docs.bazel.build/versions/master/be/python.html#py_binary_args |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a new bazel build rule for python 3 (deepmind_lab_py3.so), and added tests and examples based on the python 2 ones. I also updated the build docs to describe how to get it working with python 3. This addresses issues #40 and #33.