Skip to content

Commit

Permalink
Update devcontainer
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 550561693
Change-Id: I31c89ef43ea31db322b6dac40f954e5ae65d97ae
  • Loading branch information
jagapiou authored and Copybara-Service committed Jul 24, 2023
1 parent cb76ec5 commit 2387615
Show file tree
Hide file tree
Showing 2 changed files with 70 additions and 69 deletions.
55 changes: 27 additions & 28 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -1,32 +1,31 @@
// For format details, see https://aka.ms/devcontainer.json
{
"name": "Melting Pot",
"build": {
"dockerfile": "Dockerfile",
"context": "..",
"args": {
"PYTHON_VERSION": "3.10"
}
},
"runArgs": [
// Increase SHM sufficiently for RLlib. Note you can increase this
// further for performance gains (recommended to be at least 30% of RAM
// on large machines).
"--shm-size=6gb"
],
"postCreateCommand": "pip install --editable .[dev]",
"containerEnv": {
"PYTHONPATH": "/workspaces/meltingpot"
},
"customizations": {
"vscode": {
"extensions": [
"ms-python.python",
"ms-python.python.pylint",
"ms-python.vscode-pylance",
"ms-azuretools.vscode-docker",
"donjayamanne.githistory"
]
}
"name": "Melting Pot",
"build": {
"dockerfile": "Dockerfile",
"context": "..",
"args": {
"PYTHON_VERSION": "3.10"
}
},
"runArgs": [
// Increase SHM sufficiently for RLlib. Note you can increase this
// further for performance gains (recommended to be at least 30% of RAM
// on large machines).
"--shm-size=6gb"
],
"postCreateCommand": "pip install --editable .[dev]",
"customizations": {
"vscode": {
"extensions": [
"donjayamanne.githistory",
"ms-azuretools.vscode-docker",
"ms-python.black-formatter",
"ms-python.isort",
"ms-python.pylint",
"ms-python.python",
"ms-python.vscode-pylance"
]
}
}
}
84 changes: 43 additions & 41 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,48 +1,50 @@
// See https://code.visualstudio.com/docs/getstarted/settings
{
// Google formatting settings.
"editor.rulers": [80],
"editor.detectIndentation": false,
"editor.tabSize": 2,
"editor.insertSpaces": true,
"files.insertFinalNewline": true,
"files.trimFinalNewlines": true,
"files.trimTrailingWhitespace": true,
// Google formatting settings.
"editor.rulers": [80],
"editor.detectIndentation": false,
"editor.tabSize": 2,
"editor.insertSpaces": true,
"files.insertFinalNewline": true,
"files.trimFinalNewlines": true,
"files.trimTrailingWhitespace": true,

// Format modified lines on save.
"editor.formatOnSave": true,
"editor.formatOnSaveMode": "modifications",
// Format modified lines on save.
"editor.formatOnSave": true,
"editor.formatOnSaveMode": "modifications",

// File types used in this project.
"files.associations": {
".pylintrc": "ini"
},
// File types used in this project.
"files.associations": {
".pylintrc": "ini"
},

// Ignore Git and caches.
"files.watcherExclude": {
"**/.git/**": true
},
"files.exclude": {
"**/*.egg-info": true,
"**/.eggs": true,
"**/*.py[cod]": true,
"**/__pycache__": true,
"**/.cache": true,
"**/.pytest_cache": true,
"**/.pytype": true
},
// Ignore Git and caches.
"files.watcherExclude": {
"**/.git/**": true
},
"files.exclude": {
"**/*.egg-info": true,
"**/.eggs": true,
"**/*.py[cod]": true,
"**/__pycache__": true,
"**/.cache": true,
"**/.pytest_cache": true,
"**/.pytype": true
},

// Python settings.
"python.testing.unittestEnabled": false,
"python.testing.nosetestsEnabled": false,
"python.testing.pytestEnabled": true,
"python.linting.pylintUseMinimalCheckers": false,
"[python]": {
"editor.defaultFormatter": "ms-python.black-formatter",
"editor.codeActionsOnSave": {
"source.organizeImports": true
}
},
"python.formatting.provider": "none",
"black-formatter.path": ["pyink"]
// Python settings.
"python.testing.unittestEnabled": false,
"python.testing.nosetestsEnabled": false,
"python.testing.pytestEnabled": true,
"python.linting.pylintUseMinimalCheckers": false,
"[python]": {
"editor.defaultFormatter": "ms-python.black-formatter",
"editor.codeActionsOnSave": {
"source.organizeImports": true
}
},
"python.formatting.provider": "none",
"black-formatter.path": ["pyink"],
"isort.args": ["--resolve-all-configs"],
"isort.check": true
}

0 comments on commit 2387615

Please sign in to comment.