update gym -> gymnasium, ray=2.0.0 -> ray=2.5.0

[dimonenka]

• I tested my local (modified) rllib/self_play_train.py
• I did not test utils_test.py
• I did not test render
• Upgrading ray requires using gymnasium instead of gym, which petingzoo also relies on. However, newer versions of petingzoo also use gymnasium. I updated petingzoo example but didn't test. Chances are, this example will work with little changes, but needs testing and updating to the newer versions of petingzoo in the requirements.

Not ideal but hope it still helps.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[jagapiou]

Thanks for this. Added some comments, I don't know ray very well so they may well be ignorant :-)

FYI the pytype and test-examples actions are broken, I've got a fix incoming.

[jagapiou]

FYI: got some updates to the requirements landing soon (chex<0.1.81, unpinned tensorflow) and a fix of some of the utils_test.py.

[jagapiou]

One more change and then it's all good to go in.

Please squash your commits into one.

Thank you!

[jagapiou]

self._num_players not self.num_players please.

[dimonenka]

sorry for the bugs, trying to squash now

[dimonenka]

I'm not sure if I can squash:

• squashing seems to only work for the last n commits, meaning it would affect the commits of other collaborators
• I had to merge with main and merge commits are not allowed when squashing

[dimonenka]

Should I create a new pull request with all commits in one?

[jagapiou]

I think you should be able to do this to squash it all into one commit while keeping this PR:

git tag pr153  # for safety only
git fetch upstream
git reset --soft upstream/main
git commit -m 'update gym -> gymnasium, ray=2.0.0 -> ray=2.5.0'
git push --force

[dimonenka]

Yea I don't know, it didn't work, says there are no changes to commit

[jagapiou]

Ah sorry forgot to specify reset to upstream/main. I've updated the instructions.

[dimonenka]

This is magic, you must be a wizard.

[jagapiou]

Sorry, a few changes that weren't in your branch got reverted we should have merged upstream/main into main before squashing.

Option 1

Manually revert them and then fix and then use

git commit --amend --no-edit
git push --force

Option 2

Assuming you tagged as pr315 as above (hooray for safety tags), I think you can just git reset --hard pr153 to get back to where you were and then try again with:

git fetch upstream
git merge upstream/main  # the thing I forgot
git reset --soft upstream/main
git commit -m 'update gym -> gymnasium, ray=2.0.0 -> ray=2.5.0'
git push --force

[dimonenka]

Yep hard reset worked

[dimonenka]

Automatic tests always failed to install gymnasium -- is that ok?

[jagapiou]

Fantastic, thanks so much.

When I drop the petting zoo stuff from examples/requirements.txt the gymnasium issues went away so I think the automatic tests are failing because of a dependency conflict between pettingzoo and ray. So there's still more work updating these examples. But this has gotten us off to a good start :-)

[jagapiou]

I've trigged our pipeline that pulls this PR to our internal repo, checks it breaks nothing internally, asks someone to LGTM it, and then it will hopefully hit the public repo soon.

[dimonenka]

Cool, thanks! Let me know if something else is needed on my end.

[jagapiou]

Merged in a72757f