Tendons in USD #1714
Merged
Tendons in USD #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
abhihjoshi
commented
Jun 3, 2024
abhihjoshi
commented
- Adding support for tendons in USD
- Updating geom visibility logic for changing visibility across multiple frames
- Adding user friendly demo script for generating USD file for inputted XML file
Demo script
Shape meshes
adding demo file and unnamed geom fix
…ding frame skip arg to demo
yuvaltassa
reviewed
Jun 13, 2024
abhihjoshi
force-pushed
the
tendons
branch
2 times, most recently
from
bc27690
to
ea128c1
Compare
saran-t
approved these changes
Jun 20, 2024
xieleo5
reviewed
Jul 3, 2024
python/mujoco/usd/exporter.py
Outdated
| # post-processing for visibility of geoms in scene | ||
| for _, geom_ref in self.geom_refs.items(): | ||
| geom_ref.update_visibility(False, geom_ref.last_visible_frame+1) | ||
|
|
||
| self.stage.Export( | ||
| f"{self.output_directory_root}/{self.output_directory_name}/frames/frame_{self.frame_count}_.{filetype}" |
There was a problem hiding this comment.
Hi, is this a typo to have an additional _ after {self.frame_count}?
There was a problem hiding this comment.
I remember this was intentional prior to when we were able to render a full trajectory. However, now, I do not believe there is a reason. I can remove this.
yuvaltassa
approved these changes
Jul 5, 2024
yuvaltassa
approved these changes
Jul 7, 2024
copybara-service
bot
merged commit 60afda9
into
google-deepmind:main
12 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.