adding domino

[morLev]

No description provided.

[lanctot]

Thanks!

#1017 has been merged into master, so the problems with the tests are now fixed. Can you pull changes from master and push the merge commit?

[morLev]

Thanks!

#1017 has been merged into master, so the problems with the tests are now fixed. Can you pull changes from master and push the merge commit?

Done

[lanctot]

Done

Hmm, oddly .. the new commits are showing as part of your PR now. Ok, we'll try this and see what happens, and hopefully they get marked as reverted during the import.

I started the tests now. If they pass, then someone will do a review soon. Thanks again!

[lanctot]

Hi @morLev, the tests failed because there is no playthrough for your new game.

Can you take a look at step 9 from these instructions: https://github.com/deepmind/open_spiel/blob/master/docs/developer_guide.md#adding-a-game to generate a new playthrough, then add it to your PR?

[morLev]

Hi @morLev, the tests failed because there is no playthrough for your new game.

Can you take a look at step 9 from these instructions: https://github.com/deepmind/open_spiel/blob/master/docs/developer_guide.md#adding-a-game to generate a new playthrough, then add it to your PR?

done

[lanctot]

The domino_test is now failing when run on Github Actions. You can see the output by clicking on the failure link above. Does it work for you locally?

[morLev]

The domino_test is now failing when run on Github Actions. You can see the output by clicking on the failure link above. Does it work for you locally?

Hi,

Sorry, it was not working locally.
solve it by modifying returns() (to return [0, 0] on nonterminal states).

[lanctot]

Great, thanks. Tests are passing now. Someone will do a review soon. Once any changes are made from review, we can import it.

[lanctot]

A few quick comments now.

[lanctot]

Thanks for the updates @morLev ! Can you respond to the threads now in the PR and mark any as resolved where appropriate?

[morLev]

@lanctot
@jhtschultz

Hi,

Besides resolving your comments, I also change how the first player to play is chosen (or more accurately, what hand is playing first).
did it because the rules I know are not documented anywhere online.
so now player 0 is always playing first, which is like a coin toss or drawing lots:

Drawing Lots to Determine Who Will Make the First Play:
After the tiles are shuffled, each player draws a domino from the stock. The player who draws the heaviest tile will make the first play. If there is a tie, it is broken by drawing new dominoes from the stock.
(https://www.dominorules.com/the-basics)

[lanctot]

Thanks @morLev !

[jhtschultz]

Awesome looks good! Thanks @morLev! Great to have a dominoes game in Open Spiel :)