Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import numpy as np in concept.md #60

Merged
merged 1 commit into from
Sep 18, 2019

Conversation

srijanreddy98
Copy link
Contributor

In line 87 of concepts.md np is used but not imported. This just adds that import statement.

action = np.random.choice(action_list, p=prob_list)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@srijanreddy98
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@lanctot
Copy link
Collaborator

lanctot commented Sep 17, 2019

Good catch!

@lanctot
Copy link
Collaborator

lanctot commented Sep 17, 2019

We have integrated this PR internally, so this will go out on the next push to github. Thanks!

@srijanreddy98
Copy link
Contributor Author

Happy to help.

@lanctot
Copy link
Collaborator

lanctot commented Sep 17, 2019

Oh there was need to close it. Our push to github does that and associates the commits with it, so I like to keep it up until we do the push. (That way you and everyone else get notified when it's actually merged.)

@lanctot lanctot reopened this Sep 17, 2019
@OpenSpiel OpenSpiel merged commit 1a7a972 into google-deepmind:master Sep 18, 2019
OpenSpiel pushed a commit that referenced this pull request Sep 18, 2019
PiperOrigin-RevId: 269608835
Change-Id: If66637f5f175319415534735c934cd7a7f4df82f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants