Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backgammon narrative #66

Closed
wants to merge 7 commits into from
Closed

Backgammon narrative #66

wants to merge 7 commits into from

Conversation

jamesdfrost
Copy link
Contributor

@jamesdfrost jamesdfrost commented Sep 22, 2019

Changes to use Backgammon standard narrative formats for human readable notation, as follows:

  • Always show the numbering going from Bar->24->0->Off, irrespective of which player is moving.
  • Show the start position followed by end position, instead of start position, number of moves. E.g. 24/22 10/8
  • Show hits with an asterisk, e.g. 9/7*.
  • Order the moves by highest number first, e.g. 22/7 10/8 not 10/8 22/7. Not an official requirement, but seems to be standard convention.
  • Show duplicate moves as 10/8(2) instead of 10/8 10/8.
  • Show moves on a single piece as 10/8/5 not 10/8 8/5

Also introduced tests to check for the above scenarios.

Files changed - backgammon.cc, backgammon_test.cc and backgammon.txt (for the playthrough tests)

Install instructions for OpenSpiel on Windows 10 using Windows Subsystem for Linux version 1 (WSL)
Changed backgammon ActionToString function to show the human readable moves in standard format
Changed backgammon narratives to standard format, and introduced tests to validate this.
changed playthroughs to reflect new narratives
@lanctot
Copy link
Collaborator

lanctot commented Sep 23, 2019

Hi @jamesdfrost , this sounds great from the description. Unfortunately, though, the PR seems to have similiar issues that you were having in the other one. It's showing 6 commits, including windows.md. I'd like to keep the PRs separate so that the diffs represent only the changes that were made.

I think this is because you're probably re-using the same original branch you made for that first PR (or the new branch has the same commits.) For now, rather than figuring out how to do the branching properly on the same repos, could you try entirely from scratch: for each PR, re-clone the repos (to a different directly), create the PR, and switch to that branch only in that directory. Then copy over the backgammon.cc and backgammon_test.cc that you have and create just the one commit on that branch.

This way you could have several different branches checked out and not interacting with each other (because of them is cloned to a different directory)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants