Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backgammon notation v2 #70

Closed
wants to merge 3 commits into from
Closed

Backgammon notation v2 #70

wants to merge 3 commits into from

Conversation

jamesdfrost
Copy link
Contributor

Changes to use Backgammon standard narrative formats for human readable notation, as follows:

  • Always show the numbering going from Bar->24->0->Off, irrespective of which player is moving.
  • Show the start position followed by end position, instead of start position, number of moves. E.g. 24/22 10/8
  • Show hits with an asterisk, e.g. 9/7*.
  • Order the moves by highest number first, e.g. 22/7 10/8 not 10/8 22/7. Not an official requirement, but seems to be standard convention.
  • Show duplicate moves as 10/8(2) instead of 10/8 10/8.
  • Show moves on a single piece as 10/8/5 not 10/8 8/5
  • Also introduced tests to check for the above scenarios.

Files changed - backgammon.cc, backgammon_test.cc and backgammon.txt (for the playthrough tests)

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@lanctot
Copy link
Collaborator

lanctot commented Sep 24, 2019

@jamesdfrost , thanks. Looks good, I'll important it and hoepfully get it into our next update.

Seems like you need to sign the CLA (I think you must have had to do this for the first PR too?)

@jamesdfrost
Copy link
Contributor Author

I've signed it with my github account jamesdfrost, but VScode seems to have uploaded these files using "James Frost" - I'll fix and resubmit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants