Phantom go #867
Phantom go #867
Conversation
…ith stones visible in players observation Added a visual test for this method
Reverted changes in inicialization of new state in mentioned method, because methods from PhantomGoState are needed
… played by opponent for observation, resulting in terminal state
Updated visual test for this method
… reliably generates new resampled states Added a test to test this method on huge number of states with random histories
… of the infoState Added a visual test for Cloning
…nfostate, now only resamples a metaposition, infostate is in progress
…ring to the incomplete information
Added a method to check metaposition equality refactored metapositon resampling test
Refactored the way an observationString is created Three variables added to better describe the state Generated new playthrough to match the Observer class Removed unimportant commented code
|
Thanks! There's a conflict in pyspiel_test.py, can you resolve it? |
|
(You can ignore the failing wheels tests, they will be fixed once #873 is merged on Monday.. but you will have to rerun |
|
|
||
|
|
||
| std::vector<VirtualPoint> HandicapStones(int num_handicap) { | ||
| if (num_handicap < 2 || num_handicap > 9) return {}; |
There was a problem hiding this comment.
Would be better to raise an error in most of these cases.
|
@lanctot > Can you add the game and its description to the games page? (docs/games.md) Sorry for the delay. I am not sure what is the proper way to edit it, is there some editor? |
It is plain text file. But don't worry about it, I can do it on my end. |
|
Hi @Syor , the test is failing because it appears there is some Linux-specific code (specifically, the header |
lanctot
added
imported
No description provided.