Do not reuse mini-batches between epochs in DPSGD example. #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_410783051
branch
from
f996b23
to
ff4b517
Compare
As pointed out in #149, the dataset in the DPSGD example was converted to a list which meant that the same mini-batches were used for each epoch. This is fixed now so that the data is shuffled differently in each epoch. The change led to a small (20%) performance decrease when running on a GPU but this could be solved by prefetching batches. PiperOrigin-RevId: 411027866
copybara-service
bot
force-pushed
the
test_410783051
branch
from
ff4b517
to
4750dd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not reuse mini-batches between epochs in DPSGD example.
As pointed out in #149, the dataset in the DPSGD example was converted to a
list which meant that the same mini-batches were used for each epoch. This is
fixed now so that the data is shuffled differently in each epoch.
The change led to a small (20%) performance decrease when running on a GPU but this
could be solved by prefetching batches.